Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation text-transform component #52072 #52243

Conversation

BenjaminZekavica
Copy link
Member

Pull Request #52072

What?

  • added readme for text-transform component

How?

I added the Readme with all information how to use the text-transform component

Todo: Please upload the image on the WP Server to embed it.

wp-texttransform-doc

@BenjaminZekavica
Copy link
Member Author

Please can somebody check the Github Action, I can't understand it why the building process has an error :/ Thank u :)

Copy link
Contributor

@mburridge mburridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mburridge
Copy link
Contributor

I've also tried re-running the tests.

@BenjaminZekavica
Copy link
Member Author

BenjaminZekavica commented Jul 17, 2023

I've also tried re-running the tests.

@mburridge Thank you so much :) Do you can merged it to the Master. It's important before you start merging, that the picture has a other URL Source. Do you could upload the picture to the WP Server, than I will change the URL.

@mburridge
Copy link
Contributor

@BenjaminZekavica I'm going to try to find out the best place to upload the image to.

Some of the components put images in docs/assets, like this one. Others upload the image to Make, such as this one. While yet others have another location for images, such as this one.

Once I find out the best location for README.md images I'll advise.

@ndiego
Copy link
Member

ndiego commented Jul 17, 2023

Some of the components put images in docs/assets, like this one. Others upload the image to Make, such as this one. While yet others have another location for images, such as this one.

Once I find out the best location for README.md images I'll advise.

This is still up for debate. In the interest of getting this PR merged, let's add it to docs/assets. It can always be moved later, and this way, we have the actual image in the repo.

@BenjaminZekavica
Copy link
Member Author

BenjaminZekavica commented Jul 17, 2023

Some of the components put images in docs/assets, like this one. Others upload the image to Make, such as this one. While yet others have another location for images, such as this one.
Once I find out the best location for README.md images I'll advise.

This is still up for debate. In the interest of getting this PR merged, let's add it to docs/assets. It can always be moved later, and this way, we have the actual image in the repo.

@ndiego: That means I have to add in this PR the picture in the right folder and than I add the path inside the README.md?

@BenjaminZekavica
Copy link
Member Author

@mburridge I added the picture inside the folder docs/assets and I added the Link inside the README. It will works after merging. Than the picture will be available. I hope now you could merge.

@mburridge
Copy link
Contributor

LGTM. Great work, thanks @BenjaminZekavica 🙌. Just waiting for the checks to complete before merging.

@BenjaminZekavica
Copy link
Member Author

BenjaminZekavica commented Jul 18, 2023

LGTM. Great work, thanks @BenjaminZekavica 🙌. Just waiting for the checks to complete before merging.

@mburridge You're welcome :) I think it's done and it looks the Action Check is without errors.

@mburridge mburridge merged commit 3cb924a into WordPress:trunk Jul 18, 2023
@github-actions github-actions bot added this to the Gutenberg 16.3 milestone Jul 18, 2023
@aaronrobertshaw
Copy link
Contributor

Thanks for getting this documentation sorted while I was out of action @BenjaminZekavica, I appreciate it! 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants